Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(batch): ephemeralStorage property on job definitions #25399

Merged
merged 31 commits into from
Jun 20, 2023

Conversation

sumupitchayan
Copy link
Contributor

@sumupitchayan sumupitchayan commented May 2, 2023

Closes #25393.

Adds missing ephemeralStorage property to EcsFargateContainerDefinition and EcsFargateContainerDefinitionProps along with a unit test.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Signed-off-by: Sumu <sumughan@amazon.com>
@gitpod-io
Copy link

gitpod-io bot commented May 2, 2023

@aws-cdk-automation aws-cdk-automation requested a review from a team May 2, 2023 19:03
@github-actions github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels May 2, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label May 2, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

sumupitchayan and others added 7 commits May 2, 2023 15:13
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
@aws-cdk-automation aws-cdk-automation dismissed their stale review May 4, 2023 18:14

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Signed-off-by: Sumu <sumughan@amazon.com>
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

Signed-off-by: Sumu <sumughan@amazon.com>
@sumupitchayan sumupitchayan added the pr-linter/exempt-readme The PR linter will not require README changes label May 4, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review May 4, 2023 19:02

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@sumupitchayan sumupitchayan marked this pull request as ready for review May 5, 2023 16:47
@sumupitchayan sumupitchayan requested a review from comcalvi May 5, 2023 16:47
Copy link
Contributor

@comcalvi comcalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a rename and this is good to go

Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any information on the min/max value that is allowed? Can we create some synth time checks for them?

@kaizencc kaizencc changed the title feat(batch-alpha): add missing ephemeralStorage property feat(batch): ephemeralStorage property on job definitions May 5, 2023
sumupitchayan and others added 2 commits May 5, 2023 16:48
Co-authored-by: Calvin Combs <66279577+comcalvi@users.noreply.github.com>
Co-authored-by: Calvin Combs <66279577+comcalvi@users.noreply.github.com>
sumupitchayan and others added 5 commits May 5, 2023 16:48
…n.test.ts

Co-authored-by: Calvin Combs <66279577+comcalvi@users.noreply.github.com>
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking better!

if (props.ephemeralStorageSize!.toGibibytes() > 200) {
return ['Ephemeral Storage must be at most 200 GiB.'];
} else if (props.ephemeralStorageSize!.toGibibytes() < 21) {
return ['Ephemeral Storage must be minimum 21 GiB.'];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take a look at how we structure our other error messages and see if you can come up with the best version here.

Copy link

@gael-ft gael-ft May 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @sumupitchayan

Do you need some help to complete the PR ?
Looking at the review, this is the only comment that was not fixed.

Looking at ComputeEnvironments here an example of message could be:

ECS Fargate container '${id}' has 'ephemeralStorage' = ${props.ephemeralStorageSize} > 200 GiB; 'ephemeralStorage' cannot be greater than 200 GiB

Sorry in advance for direct ping, but it is about a week without any change and we're looking actively on this fix as it would avoid us stepping back from alpha package ...

@sumupitchayan sumupitchayan requested a review from kaizencc May 17, 2023 16:21
Copy link
Contributor

@comcalvi comcalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, some minor comments.

Signed-off-by: Sumu <sumughan@amazon.com>
Copy link
Contributor

@comcalvi comcalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor formatting, but this is looking good!

sumupitchayan and others added 3 commits June 8, 2023 14:57
Co-authored-by: Calvin Combs <66279577+comcalvi@users.noreply.github.com>
Co-authored-by: Calvin Combs <66279577+comcalvi@users.noreply.github.com>
Copy link
Contributor

@comcalvi comcalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Nice work on this fix 🙂

Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few minor comments too 🫣

Signed-off-by: Sumu <sumughan@amazon.com>
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

@mergify
Copy link
Contributor

mergify bot commented Jun 20, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 97fded2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit a8768f4 into main Jun 20, 2023
@mergify mergify bot deleted the sumughan/batch-add-ephemeralstorage-prop branch June 20, 2023 19:41
@mergify
Copy link
Contributor

mergify bot commented Jun 20, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 pr-linter/exempt-readme The PR linter will not require README changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-batch-alpha: Missing ephemeralStorage configuration
5 participants